Skip to content

Add ViewGeometryDualTest case #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kyle-Ye merged 1 commit into from
Jan 17, 2026
Merged

Add ViewGeometryDualTest case #728

Kyle-Ye merged 1 commit into from
Jan 17, 2026
+47 −0

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Jan 17, 2026 •
edited
Loading

Background #716

@augmentcode
Copy link

augmentcode bot commented Jan 17, 2026

🤖 Augment PR Summary

Summary: Adds a new SymbolLocator-backed dual test for SwiftUI’s internal ViewGeometry.isInvalid behavior.

Changes:

  • Introduced a Darwin-only C stub (ViewGeometryTestsStub.c) that resolves the SwiftUI mangled symbol for ViewGeometry.isInvalid.
  • Added a new dual test (ViewGeometryDualTests.swift) that bridges to the stub via @_silgen_name and compares OpenSwiftUI’s ViewGeometry.isInvalid with SwiftUI’s implementation.
  • Parameterized test cases cover NaN/infinity/finite origin values for consistent cross-implementation validation.

Technical Notes: The test is gated behind canImport(SwiftUI, _underlyingVersion: 6.5.4) and relies on SymbolLocator stubs only on Darwin platforms.

🤖 Was this summary useful? React with 👍 or 👎

augmentcode[bot]
augmentcode bot reviewed Jan 17, 2026
View reviewed changes
Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@Kyle-Ye Kyle-Ye requested a review from pookjw January 17, 2026 17:01
pookjw
pookjw approved these changes Jan 17, 2026
View reviewed changes
Copy link
Member

@pookjw pookjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Jan 17, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.34%. Comparing base (2b0e0b5) to head (8dd7b50).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
- Coverage   28.35%   28.34%   -0.02%     
==========================================
  Files         602      602              
  Lines       36677    36677              
==========================================
- Hits        10401    10396       -5     
- Misses      26276    26281       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit ad4afc5 into main Jan 17, 2026
10 of 11 checks passed
@Kyle-Ye Kyle-Ye deleted the k-branch-1 branch January 17, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@augmentcode augmentcode[bot] augmentcode[bot] left review comments

@pookjw pookjw pookjw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kyle-Ye @pookjw